feat: Add support for hasconfig git rule.#2075
Merged
Byron merged 2 commits intogitpython-developers:mainfrom Oct 8, 2025
bvanelli:2017-support-hasconfig-remote-url
Merged
feat: Add support for hasconfig git rule.#2075Byron merged 2 commits intogitpython-developers:mainfrom bvanelli:2017-support-hasconfig-remote-url
Byron merged 2 commits intogitpython-developers:mainfrom
bvanelli:2017-support-hasconfig-remote-url
Conversation
Byron
approved these changes
Oct 8, 2025
Member
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
Thanks so much for contributing this capability!
I really like the implementation, and love that there are tests as well.
To my mind these tests cover the most important cases.
Good to merge!
|
|
||
| elif keyword == "hasconfig:remote.*.url": | ||
| for remote in self._repo.remotes: | ||
| if fnmatch.fnmatchcase(remote.url, value): |
Member
There was a problem hiding this comment.
Using a case-sensitive search is correct here, Git does the same.
|
|
||
| # Ensure that config with hasconfig and incorrect url is incorrect. | ||
| with open(path1, "w") as stream: | ||
| stream.write(template.format("incorrect", path2)) |
Member
There was a problem hiding this comment.
I think that "incorrect" fails to communicate that this is a URL that simply doesn't match.
Maybe something for a follow-up.
Contributor
Author
|
Oh, such speed, thanks for the quick response! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support adding custom paths for the following git config:
According to the documentation:
So I have matched the condition exactly word to word with
hasconfig:remote.*.url. I then go over the list of remotes and find usingfnmatchcasethe correct remote (not sure iffnmatch.Maybe a list of open points here:
Closes #2017